wl: Remove CogWlPlatform::init_web_view() #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaavedra
force-pushed
the
psaavedra/fix_defines_both_get_view_type_and_init_web_view_warning
branch
from
91cc7d1
to
24bd92d
Compare
aperezdc
reviewed
Oct 27, 2023
aperezdc
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Feel free to push the small fix and land the PR, @psaavedra 🙏🏼
All the initialization done in the init_web_view() is now relocated inside of the cog_wl_view_init(). To make this possible all the code related to the "run-file-chooser" and "mouse-target-changed" signals have be moved from the cog-platform-wl to the cog-view-wl. This change makes the Wayland platform compatible with the check implemented in the cog_platform_init_web_view(): "CogWlPlatform class defines both .get_view_type and .init_web_view the latter should be removed."
... if class defines both .get_view_type and .init_web_view. This brings again the change reverted in "wl: Remove early return on cog_platform_init_web_view()".
psaavedra
force-pushed
the
psaavedra/fix_defines_both_get_view_type_and_init_web_view_warning
branch
from
24bd92d
to
e9bbd74
Compare
psaavedra
deleted the
psaavedra/fix_defines_both_get_view_type_and_init_web_view_warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the initialization done in the init_web_view() is now relocated inside of the cog_wl_view_init(). To make this possible all the code related to the "run-file-chooser" and "mouse-target-changed" signals have be moved from the cog-platform-wl to the cog-view-wl.
This change makes the Wayland platform compatible with the check implemented in the cog_platform_init_web_view(): "CogWlPlatform class defines both .get_view_type and .init_web_view the latter should be removed."
Also adds again the early return in cog_platform_init_web_view() if class defines both .get_view_type and .init_web_view.