Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old Cubic EoS #1519

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dallan-keylogic
Copy link
Contributor

Summary/Motivation:

The old cubic equation of state has not been updated to have correct formulae for partial molar Gibbs and Helmholtz free energy, and doesn't have any formulae for heat capacity or speed of sound. Since it's been made obsolete by the cubic EoS implemented through the Modular Property Framework, there's no reason to keep it around to confuse people.

Changes proposed in this PR:

  • Deprecate old Cubic EoS property block, parameter block, and initializer.
  • Deprecate BT Peng-Robinson class based on old Cubic EoS

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.99%. Comparing base (2e5a9a4) to head (eb41ff6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
- Coverage   76.99%   76.99%   -0.01%     
==========================================
  Files         384      384              
  Lines       62076    62079       +3     
  Branches    10158    10158              
==========================================
  Hits        47798    47798              
- Misses      11861    11865       +4     
+ Partials     2417     2416       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dallan-keylogic dallan-keylogic marked this pull request as ready for review November 4, 2024 20:00
@dallan-keylogic dallan-keylogic self-assigned this Nov 4, 2024
@dallan-keylogic dallan-keylogic added Priority:High High Priority Issue or PR backward-compat Affects backward compatibility deprecation Add deprecation to codebase and/or remove deprecated feature labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-compat Affects backward compatibility deprecation Add deprecation to codebase and/or remove deprecated feature Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants