-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rank text seems not in the center of circle #2
base: main
Are you sure you want to change the base?
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @HwangTaehyun on Vercel. @HwangTaehyun first needs to authorize it. |
Hi @kurt-liao! |
I check your changes, but it does not work on the desktop chrome. However, I noticed that the rank is not centered in mobile chrome. Is any other method to center the rank text by SVG's CSS property? |
I think I've found the solution here and also I commit the new version. Uses Also, I've tried it on desktop chrome, it seems fine. |
Thanks! Open source hooray🎉 |
@kurt-liao Actually, I think before changes have more centered rank text than after changes. In this code, SVG's relative positions are literally weird. So, I want to fix them.
Doing this would be really/very helpful to this repo and the center problem also will be resolved. |
ce4c3d5
to
891d24b
Compare
Ok |
Hi, thanks for this wonderful project. I found that rank text looks not center of the circle, so I changed the
cx
andcy
for the circle. You can see the effect after changed:Before
After
I've created Stack Overflow stats card which also inspired by github-readme-stats. Just too happy to see your intersting project, so want to share mine with you😀.