Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11: fix _nSetTitle return type #293

Merged
merged 1 commit into from
Sep 27, 2024
Merged

X11: fix _nSetTitle return type #293

merged 1 commit into from
Sep 27, 2024

Conversation

dzaima
Copy link
Contributor

@dzaima dzaima commented Sep 24, 2024

Fixes spurious errors, as the C function has a void return type, thus leaving garbage where JNI expects an object reference. Caused weird NPEs with clang++ 18 on titles longer than 23 chars.

@tonsky tonsky merged commit 9756db3 into HumbleUI:main Sep 27, 2024
4 checks passed
@tonsky
Copy link
Collaborator

tonsky commented Sep 27, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants