typedb 2.29.1 #194822
Open
typedb 2.29.1 #194822
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `typedb` formula hasn't been updated since 2.23.0, as upstream now splits release assets into arm64 and x86_64 archives (so `brew bump-formula-pr` produces a broken `url`). This updates to the latest version, 2.29.1, but it requires a somewhat ridiculous approach (the cask DSL has a more elegant way of handling some of this). Besides that, the license changed to MPL 2.0 in version 2.28.0.
github-actions
bot
added
the
java
carlocab
reviewed
Oct 18, 2024
Comment on lines
+13
to
+32
| on_arm do | ||
| on_macos do | ||
| url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-mac-arm64-2.29.1.zip" | ||
| sha256 "1270565acd7d5c61475831dac408f2069533ecf4ffee416ae474962ce1a71603" | ||
| end | ||
| on_linux do | ||
| url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-linux-arm64-2.29.1.tar.gz" | ||
| sha256 "4846e0496c9d90542fe677bd44ec78fe31a056a07770b5b53703ea0c781e99d6" | ||
| end | ||
| end | ||
| on_intel do | ||
| on_macos do | ||
| url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-mac-x86_64-2.29.1.zip" | ||
| sha256 "82ad962d3248d0a883d129a01b7593960031758283270128601a948be637854a" | ||
| end | ||
| on_linux do | ||
| url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-linux-x86_64-2.29.1.tar.gz" | ||
| sha256 "4b358ee8beb76f856ca21c61979828f9e082f00591942bf770a1cb2aa53fe4bf" | ||
| end | ||
| end |
There was a problem hiding this comment.
Looks suspicious TBH. Doesn't seem compatible with https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?The
typedbformula hasn't been updated since 2.23.0, as upstream now splits release assets into arm64 and x86_64 archives (sobrew bump-formula-prproduces a brokenurl). This updates to the latest version, 2.29.1, but it requires a somewhat ridiculous approach (the cask DSL has a more elegant way of handling some of this).The previous repository (vaticle/typedb) now redirects to typedb/typedb (and the vaticle organization says "Moved to: https://github.com/typedb"), so this updates the URL accordingly.
Besides that, the license changed to MPL 2.0 in version 2.28.0: https://github.com/typedb/typedb/blob/2.28.0/LICENSE