Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fq: fix test on ARM #159166

Merged
merged 1 commit into from
Jan 7, 2024
Merged

fq: fix test on ARM #159166

merged 1 commit into from
Jan 7, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Jan 6, 2024

Try to fix:
curl: (7) Failed to connect to 127.0.0.1 port 8765 after 4 ms: Connection refused

on macOS ARM

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka added the CI-no-bottles Merge without publishing bottles label Jan 6, 2024
@github-actions github-actions bot added the no ARM bottle Formula has no ARM bottle label Jan 6, 2024
@iMichka iMichka marked this pull request as draft January 6, 2024 14:46
@iMichka iMichka added the test failure CI fails while running the test-do block label Jan 6, 2024
@iMichka
Copy link
Member Author

iMichka commented Jan 6, 2024

Still not fixed:
curl: (7) Failed to connect to 127.0.0.1 port 49245 after 10 ms: Connection refused

@Bo98
Copy link
Member

Bo98 commented Jan 6, 2024

Could not determine host address, use -n

Try to fix:
curl: (7) Failed to connect to 127.0.0.1 port 8765 after 4 ms: Connection refused

on macOS ARM
@iMichka iMichka marked this pull request as ready for review January 6, 2024 22:18
@iMichka iMichka requested a review from Bo98 January 6, 2024 22:18
@iMichka
Copy link
Member Author

iMichka commented Jan 6, 2024

Found it: it was not able to find a hostname by itself. It's unclear to me why this need the public facing IPV4 address of the machine ...
There is an auto detection that is done in the code, but it fails. Passing the address with -n worked.

@iMichka iMichka removed the test failure CI fails while running the test-do block label Jan 6, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 7, 2024
Merged via the queue into Homebrew:master with commit 9597cb2 Jan 7, 2024
23 checks passed
@iMichka iMichka deleted the fq branch January 7, 2024 20:22
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants