[#17] Strip field name prefixes

[chshersh]

Resolves #17

I've checked in the ghci. Seems to work:

λ: data User = User { userHeh :: String, userMeheh :: Int } deriving (Show, Generic)
λ: instance Elm User
λ: toElmDefinition (Proxy @User)
DefAlias (ElmAlias {elmAliasName = "User", elmAliasFields = ElmRecordField {elmRecordFieldType = TypeName {unTypeName = "[Char]"}, elmRecordFieldName = "heh"} :| [ElmRecordField {elmRecordFieldType = TypeName {unTypeName = "Int"}, elmRecordFieldName = "meheh"}]})

[vrom911]

👍

[vrom911]

🎉

[silky]

could we make this a configuration option? it turns out to be inconvenient sometimes

[jhrcek]

Could you please open an issue and give us a basic idea on how you'd like this to be configurable?
Something like what aeson is doing?

customOptions = defaultOptions
                { fieldLabelModifier = map toUpper
                }

instance ToJSON Coord where
    toJSON     = genericToJSON customOptions
    toEncoding = genericToEncoding customOptions

We can consider implementing it, but no guarantees about timeline.

[silky]

yes; bafflingly that's what i'm trying, but it seems overriding the options via the toJSON instance doesn't even get triggered when writing the json?!

( is that because the Elm instance overrides it? )

-- edit:

my bad, i see now that that is obvious.

yes, i'm just looking to have that function stripTypeNamePrefix be part of the Settings ( https://hackage.haskell.org/package/elm-street-0.2.0.0/docs/Elm-Generate.html ) somehow.

[turboMaCk]

interactions between Elm instance and aeson's FromJSON and ToJSON instances are a bit weird and can brake things. See for instance #115

It all depends on how you're deriving the ToJSON and FromJSON.

[jhrcek]

It won't be that easy.
You have to realize that allowing arbitrary field name modification in FromJSON / ToJSON would have to be properly reflected in the elm Encoders / Decoders generated by the library.

[silky]

i got confused, the point is stripTypeNamePrefix is always used here - https://github.com/Holmusk/elm-street/blob/master/src/Elm/Generic.hs#L272 - that's where it'd be great to configure it.

[silky]

call me crazy @jhrcek but if that function is customisable, i think everything else would just follow through, no? what would go wrong?

[jhrcek]

Not saying it's impossible, just that it would not just be matter of extracting field label modifier within To/FromJSON instances but probably larger change.

[silky]

do you want me to make a new issue for this?

[turboMaCk]

yes please open new issue for this. Also feel free to submit PR. We will still need to test it and review it and if it seems solid I don't see a reason why it would not get accepted.