Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing php-cs-fixer with pint and running pint #39

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

sukuasoft
Copy link
Contributor

@roberto-butti
This pull request is related to issue #35.

I removed the php-cs-fixer dependency, and the scripts that were in the composer.json file related to this dependency,
and replaced it with the pint dependency and added the script related to pint to the composer.json file. And thus resolving the replacement issue.

Create the pint configuration file and set it to the PER style pattern, and then run the pint script so that the current code changes following the PER pattern.

I also removed the .php-cs-fixer.dist.php file that served as one of the php-cs-fixer configuration files, and I also removed one of the workflow files from this same dependency.

In short, this was everything I changed in the project and carried out the tests, and they passed happily.

@aosccode

@roberto-butti
Copy link
Contributor

Great PR @sukuasoft !
I'm going to merge it!

Roberto

@roberto-butti roberto-butti merged commit a86ce58 into Hi-Folks:main Oct 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants