Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch remote i18n (partial - for channels only) #243

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Conversation

marrouchi
Copy link
Contributor

@marrouchi marrouchi commented Oct 18, 2024

Motivation

The following PR:

  • Add a hook to load i18n translations from the API (channels settings)
  • Enforce typing in channel and establish type safeguards
  • Enhances Settings typing
  • Establish distinction in naming of extension vs group (hyphen vs underscore)

How to test

AC :

  • Settings should show the channels settings : Web channel and Livechat tester
  • The live chat tester should work as expected in the visual editor
  • The widget should continue to work as well (both in container and as a wordpress plugin for example)

Related PR:

Hexastack/hexabot-channel-messenger#2

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marrouchi marrouchi marked this pull request as ready for review October 18, 2024 16:55
@marrouchi marrouchi changed the title feat: fetch remote i18n feat: fetch remote i18n (partial - for channels only) Oct 19, 2024
Copy link
Contributor

@yassinedorbozgithub yassinedorbozgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Settings ✅
    image

  • Visual editor ✅
    image

  • WordPress ✅
    image

LGTM 🚀

@marrouchi marrouchi merged commit 95f45b7 into main Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants