Replace pbkdf2 by Argon2 in registrar #81
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the current PBKDF2 password by Argon2 from the argonautica crate.
The tests looks good, so I did not find anything to add.
The only thing that I recon might be a point of concern is that store and check handles
[u8]
, whileHasher
operates onString
, so I handle the utf8 conversion.I'm not quite sure that no security implications are hidden in there.