Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradient computation #81

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix gradient computation #81

wants to merge 14 commits into from

Conversation

HenKlei
Copy link
Owner

@HenKlei HenKlei commented Apr 28, 2023

No description provided.

@HenKlei HenKlei added fix Fixes a bug new feature Implements a new feature labels Apr 28, 2023
@HenKlei HenKlei self-assigned this Apr 28, 2023
@HenKlei HenKlei force-pushed the fix-gradient-computation branch 2 times, most recently from a10c135 to 0f7592e Compare May 2, 2023 07:19
@HenKlei HenKlei mentioned this pull request May 4, 2023
Open
2 tasks
@HenKlei
Copy link
Owner Author

HenKlei commented Aug 17, 2023

The gradient scaling part is now (besides some other commits) included in #83.

This PR needs to be rebased on main once #83 is merged. Afterwards, it has to be checked which commits in this branch are still of interest.

@HenKlei
fixed scaling in gradient computation
28d19e3
@HenKlei
added plot of singular values to summary
6bbb2aa
@HenKlei
new test for regularizer and its inverse
b4bcaef
@HenKlei
extended test of regularizer
5c4d9ba
@HenKlei
assert that order of norm is correct if product operator is used
df0f95a
@HenKlei
adjusted norm computation for energy during geodesic shotting
826dea9
@HenKlei
added some more plots in circle scaling example
bcf2abe
@HenKlei
adjusted regularization parameters in examples and tests
86b7d04
@HenKlei
fixed linting errors
9eb9595
@HenKlei
fixed translation test and example
d88d752
@HenKlei
improved summary by extending output
40d837f
@HenKlei
fixed linting error and adjusted tolerance in test
688815a
@HenKlei
fixed saving of plots with multiple subfigures in summary
d63f0d2
@HenKlei
fixed and improved landmark matching
8cde6c8 
Implemented Newton's method on transversality condition and fixed some
bugs. Added test for commutativity in computation of differential.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HenKlei HenKlei

Labels
fix Fixes a bug new feature Implements a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HenKlei