Allow changing toolbar icon and codes #1110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customizing icons was already planned, will be implemented here.
Since people want ever more toolbar keys, and adding everything myself is annoying and makes the toolbar selection menu horribly long, I decided to add the code customization in the same menu.
What's missing
actually saving the settingssanity check for the codes (usingcheckAndConvertCode
)restriction of theEditText
fields (either to numbers, or allow labels withprocessCode
)disable ok button of key code not oknicer key selection dialogreadout of customized toolbar key codestestingstrings for everything