Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing toolbar icon and codes #1110

Merged
merged 14 commits into from
Sep 23, 2024
Merged

Allow changing toolbar icon and codes #1110

merged 14 commits into from
Sep 23, 2024

Conversation

Helium314
Copy link
Owner

@Helium314 Helium314 commented Sep 15, 2024

Customizing icons was already planned, will be implemented here.
Since people want ever more toolbar keys, and adding everything myself is annoying and makes the toolbar selection menu horribly long, I decided to add the code customization in the same menu.

What's missing

  • actually saving the settings
  • sanity check for the codes (using checkAndConvertCode)
  • restriction of the EditText fields (either to numbers, or allow labels with processCode)
  • disable ok button of key code not ok
  • nicer key selection dialog
  • readout of customized toolbar key codes
  • testing
  • strings for everything
  • some dummy toolbar keys that are just for doing custom stuff (when people don't want to modify other keys)
  • maybe find a way to show the size difference between holo and other icons when customizing icons

@Helium314 Helium314 marked this pull request as ready for review September 23, 2024 18:35
@Helium314
Copy link
Owner Author

I guess this is fine good enough now...

@Helium314 Helium314 merged commit 05523ec into main Sep 23, 2024
1 check passed
@Helium314 Helium314 deleted the toolbar_key branch September 23, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant