Fix: Eslint parsing #339

tuliomir · 2024-11-04T16:27:25Z

Wraps up the work started by style: Automatic lint fixes and formatting #291 and style: Manual lint fixes #294
Fixes a parsing error that was preventing lint from running on all the modified files in this PR
Implements all automatic lint fixes for those files
Implements all manual lint fixes for those files

The prettier fixes were already implemented, as the parsing problem was only happening for Eslint.

Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

tuliomir added the refactor label Nov 4, 2024

tuliomir self-assigned this Nov 4, 2024

tuliomir requested a review from r4mmer as a code owner November 4, 2024 16:27

r4mmer previously approved these changes Nov 4, 2024

View reviewed changes

tuliomir requested review from pedroferreira1 and andreabadesso and removed request for pedroferreira1 November 4, 2024 18:37

andreabadesso previously approved these changes Nov 4, 2024

View reviewed changes

tuliomir added 7 commits November 5, 2024 12:23

fix: eslint parser config

a09f1ff

style: eslint automatic fixes

1f762f4

style: simple eslint fixes

7aeec14

style: key eslint fixes

9d02dea

style: ternary eslint fix

91d126e

chore: adds linting to the CI workflow

167377c

style: minor fix after rebasing

c8e8cf9

tuliomir dismissed stale reviews from andreabadesso and r4mmer via c8e8cf9 November 5, 2024 15:26

tuliomir force-pushed the fix/eslint-parsing branch from b7412f7 to c8e8cf9 Compare November 5, 2024 15:26

r4mmer self-requested a review November 5, 2024 16:04

r4mmer approved these changes Nov 5, 2024

View reviewed changes

andreabadesso approved these changes Nov 5, 2024

View reviewed changes

tuliomir merged commit 3c2d1e7 into dev Nov 5, 2024
1 check passed

tuliomir deleted the fix/eslint-parsing branch November 5, 2024 16:45

Provide feedback