Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error message when decode tx fails #332

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

pedroferreira1
Copy link
Member

Context

#331

The decode-tx API does not return success: False when the decoding fails, that's why the current code has a bug.

Acceptance Criteria

  • The error message should be correctly shown when decoding an invalid tx.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer linked an issue Oct 1, 2024 that may be closed by this pull request
@pedroferreira1 pedroferreira1 merged commit 096441d into dev Oct 3, 2024
1 check passed
@pedroferreira1 pedroferreira1 deleted the fix/decode-tx-error branch October 3, 2024 16:51
@luislhl luislhl mentioned this pull request Oct 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Decode screen: invalid tx error
3 participants