refactor: TransactionDetail.js to functional component #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliomir
commented
Aug 22, 2024
| setConfirmationData(confirmationDataResponse); | ||
| } | ||
|
|
||
| // Get transaction metadata from explorer service, overwriting the one already obtained |
There was a problem hiding this comment.
Note: This logic of overwriting the meta state was already present, I just made it more obvious by removing the intermediate functions that were doing the double work.
This may be fixed or better structured at a future moment, but the scope of this PR is only to refactor and not to change the logic.
tuliomir
force-pushed
the
refactor/txdetail-functional
branch
from
1dab0a8
to
23399cb
Compare
andreabadesso
approved these changes
Aug 27, 2024
r4mmer
approved these changes
Aug 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
TransactionDetailscreen to a functional componentNotes
Just like what happened with #296 , despite the logic staying the same, this code was changed a lot. This makes the
diffhard to read. The best way to review this screen is to open the before and after to look at the changes.Security Checklist