chore: Upgrade Bootstrap from v4 to v5 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliomir
added
dependencies
tuliomir
force-pushed
the
chore/upgrade-bootstrap
branch
from
3a78199
to
666fb23
Compare
tuliomir
force-pushed
the
chore/upgrade-bootstrap
branch
from
666fb23
to
b152a11
Compare
r4mmer
approved these changes
Aug 21, 2024
andreabadesso
approved these changes
Aug 21, 2024
| @@ -165,10 +165,10 @@ function Navigation({ history }) { | |||
| </div> | |||
| </li> | |||
| </ul> | |||
| <div className="navbar-right d-flex flex-row align-items-center navigation-search"> | |||
| <div className="d-flex flex-row align-items-center ms-auto navigation-search"> | |||
There was a problem hiding this comment.
navbar-right not needed anymore?
There was a problem hiding this comment.
Not anymore, this behavior is now by default ( link )
I just added an utility for "margin-right: automatic" so that the search box would stay on the right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
A quick visualization of the visual changes can be seen on the video below.
The tab with the green margins is the one with Bootstrap 5 running on developer localhost, while the one without the border is the existing Bootstrap 4 running on public testnet.
Screencast.from.20-08-2024.20.19.50.webm
Security Checklist