feat: add list pagination to the nano contract history table #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
force-pushed
the
feat/nano-history-pagination
branch
from
84b541c
to
b8e632b
Compare
tuliomir
reviewed
Aug 19, 2024
r4mmer
reviewed
Aug 19, 2024
| * otherwise it would be fixed the moment the event listener is started in the useEffect | ||
| * with the history as an empty array | ||
| * | ||
| * tx {Transaction} Transaction object that arrived from the websocket |
There was a problem hiding this comment.
Suggested change
| * tx {Transaction} Transaction object that arrived from the websocket | |
| * @param {Transaction} tx Transaction object that arrived from the websocket |
Comment on lines
84
to
85
| * after {string | null} Hash to use for pagination when user clicks to fetch the next page | ||
| * before {string | null} Hash to use for pagination when user clicks to fetch the previous page |
There was a problem hiding this comment.
Suggested change
| * after {string | null} Hash to use for pagination when user clicks to fetch the next page | |
| * before {string | null} Hash to use for pagination when user clicks to fetch the previous page | |
| * @param {string | null} after Hash to use for pagination when user clicks to fetch the next page | |
| * @param {string | null} before Hash to use for pagination when user clicks to fetch the previous page |
There was a problem hiding this comment.
Done, thanks ab25623
pedroferreira1
force-pushed
the
feat/nano-history-pagination
branch
from
7f04289
to
86d1258
Compare
tuliomir
approved these changes
Aug 20, 2024
r4mmer
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
nano.history.pagination.mov
Depends on
HathorNetwork/hathor-explorer-service#331
https://github.com/HathorNetwork/nano-hathor-core/pull/95
Security Checklist