-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Styles #465
feat: Styles #465
Conversation
@tazlin I believe this PR is ready for a squash merge. The test pass in the dev horde, but fail in the github actions because the SDK is not aware of the new endpoints. I suspect this is not a blocking point as the SDK can be updated at a later time. Do take a look at the PR to see if you notice anything suspcious, although with 2.5K of linechanges I don't expect that you will dig into everything. |
This just brings the testing up to the point of only failing on the unsupported/not yet added endpoints. See Haidra-Org/AI-Horde#465 for more information.
This just brings the testing up to the point of only failing on the unsupported/not yet added endpoints. See Haidra-Org/AI-Horde#465 for more information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you noted, the tests fail due to a lack of definitions only at this point. Given the nature of the changes, I believe that any issues with the new validation will get sorted out by user-driven reports. The style feature itself is so heavily dependent on front-end integration at this point - leaving the impacted audience at very small numbers - that it should be safe to move forward for now.
customizer
role to make styles for text or imagename
, oruser::name
, orstyle::name
oruser::style::name
Also finally upgrades sqlalchemy