Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Styles #465

Merged
merged 21 commits into from
Nov 3, 2024
Merged

feat: Styles #465

merged 21 commits into from
Nov 3, 2024

Conversation

db0
Copy link
Member

@db0 db0 commented Oct 28, 2024

  • Allows anyone with the customizer role to make styles for text or image
  • Styles can include any of the params for those gens, or only some of them
  • Styles must have a pre-specified model list
  • Styles can be used via ID or name, or user::name, or style::name or user::style::name
  • Adds all API endpoints
  • Allows anyone to group any number of styles together into a single collection
  • When a collection is used as the style of a request, a random style is applied from those inside

Also finally upgrades sqlalchemy

@db0 db0 marked this pull request as draft October 28, 2024 19:18
@db0 db0 marked this pull request as ready for review November 3, 2024 16:04
@db0 db0 added the allow-ci A PR with this label will run through CI. label Nov 3, 2024
@db0 db0 requested a review from tazlin November 3, 2024 16:26
@db0
Copy link
Member Author

db0 commented Nov 3, 2024

@tazlin I believe this PR is ready for a squash merge. The test pass in the dev horde, but fail in the github actions because the SDK is not aware of the new endpoints.

I suspect this is not a blocking point as the SDK can be updated at a later time. Do take a look at the PR to see if you notice anything suspcious, although with 2.5K of linechanges I don't expect that you will dig into everything.

tazlin added a commit to Haidra-Org/horde-sdk that referenced this pull request Nov 3, 2024
This just brings the testing up to the point of only failing on the unsupported/not yet added endpoints.

See Haidra-Org/AI-Horde#465 for more information.
tazlin added a commit to Haidra-Org/horde-sdk that referenced this pull request Nov 3, 2024
This just brings the testing up to the point of only failing on the unsupported/not yet added endpoints.

See Haidra-Org/AI-Horde#465 for more information.
Copy link
Member

@tazlin tazlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you noted, the tests fail due to a lack of definitions only at this point. Given the nature of the changes, I believe that any issues with the new validation will get sorted out by user-driven reports. The style feature itself is so heavily dependent on front-end integration at this point - leaving the impacted audience at very small numbers - that it should be safe to move forward for now.

@db0 db0 merged commit b65e9c6 into main Nov 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-ci A PR with this label will run through CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants