WIP: Fix member count inaccurate in Guilds and Parties #15314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12286
Changes
Hi there! I've been working on this issue, continuing from the work done in #14203.
Based on the previously implemented content, I've implemented a transaction-based approach.
In addition, I've added error messages for situations that may occur if the transaction fails.
Questions
I have a couple of questions about the implementation.
Regarding error handling, I've extended
InternalServerError
to createDatabaseError
andTransactionError
. I'm wondering if this is the right approach.For testing purposes, I'm trying to reproduce this issue locally.
Do you have any suggestions on how to set up a group for a test account without triggering group plan payments? I'm not quite sure how to navigate this.
Any guidance you can provide on these questions would be really helpful. Thanks!
UUID: 02dac320-60bd-4178-8154-11bc222d4419