Fix performance of top_p and top_k calculations #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkuligowski
approved these changes
Oct 30, 2024
imangohari1
pushed a commit
to imangohari1/vllm-fork
that referenced
this pull request
Oct 31, 2024
This change is fixing the performance issue I have introduced in the PR HabanaAI#414 -- due to the usage of `torch.where` both functions have been called. Now we will run only the selected one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is fixing the performance issue I have introduced in the PR #414 -- due to the usage of
torch.whereboth functions have been called. Now we will run only the selected one.