Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hpu destructors flow and remove finish_measurements #379

Open
wants to merge 1 commit into
base: habana_main
Choose a base branch
from
Open

fix hpu destructors flow and remove finish_measurements #379

wants to merge 1 commit into from

Conversation

nirda7
Copy link

@nirda7 nirda7 commented Oct 10, 2024

Fix hpu related destructors flow, avoiding multiple calls to the same shutdown function.
Remove the use of the finish_measurements function.

This was referenced Oct 11, 2024
Open
Open
kzawora-intel
kzawora-intel reviewed Oct 14, 2024
View reviewed changes
Copy link

@kzawora-intel kzawora-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but let's add a guard against AttributeError in the destructor by using getattr (in case executor's destructor gets called before _init_executor())

vllm/executor/ray_hpu_executor.py Outdated Show resolved Hide resolved
vllm/executor/hpu_executor.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzawora-intel kzawora-intel kzawora-intel left review comments

@Tiefen-boop Tiefen-boop Tiefen-boop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirda7 @Tiefen-boop @kzawora-intel