Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual join from groups_of_stop_places_members to stop_places #229

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Huulivoide
Copy link
Contributor

@Huulivoide Huulivoide commented Jun 25, 2024

This change is Reviewable

Copy link
Contributor

@culka culka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Huulivoide)


-- commits line 2 at r1:
nit group_of_... 🙂


metadata/hsl/databases/stops/tables/public_group_of_stop_places_members.yaml line 12 at r1 (raw file):

        insertion_order: null
        remote_table:
          name: stop_place

I think it would be better to reference stop_place_newest_version view here, so there can be no extra old stop versions when fetching the member stops.

Copy link
Contributor

@culka culka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Huulivoide)

@Huulivoide Huulivoide merged commit 567bbda into main Jun 27, 2024
10 of 11 checks passed
@Huulivoide Huulivoide deleted the GroupToStop branch June 27, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants