Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stop_place_newest_version metadata #227

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

HenrikHartiala
Copy link
Contributor

@HenrikHartiala HenrikHartiala commented Apr 18, 2024

Add the necessary metadata to track stop_place_newest_version which
is a view that only has the newest versions of a stop (distincted by netex_id).
Also add the necessary relationships, a remote relationship to tiamat API
stop place and remote relationship to scheduled_stop_point. We might have
use for both, or only one of these remote relationships, but should be
no harm in adding both.

Resolves https://dev.azure.com/hslfi/JORE%204.0/_workitems/edit/35459


This change is Reviewable

@HenrikHartiala HenrikHartiala force-pushed the add-stop-place-newest-version-metadata branch 2 times, most recently from 55dfe1e to d1fbf14 Compare April 22, 2024 11:31
Add the necessary metadata to track stop_place_newest_version which
is a view that only has the newest versions of a stop (distincted by netex_id).
Also add the necessary relationships, a remote relationship to tiamat API
stop place and remote relationship to scheduled_stop_point. We might have
use for both, or only one of these remote relationships, but should be
no harm in adding both.

Resolves https://dev.azure.com/hslfi/JORE%204.0/_workitems/edit/35459
@HenrikHartiala HenrikHartiala force-pushed the add-stop-place-newest-version-metadata branch from d1fbf14 to ad9a9cc Compare April 22, 2024 11:35
Copy link
Contributor

@culka culka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @HenrikHartiala)

@HenrikHartiala HenrikHartiala merged commit e9d5cd9 into main Apr 22, 2024
11 checks passed
@HenrikHartiala HenrikHartiala deleted the add-stop-place-newest-version-metadata branch April 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants