-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directly read from the Tiamat database #226
Conversation
35189f0
to
145d49f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 102 files at r1.
Reviewable status: 3 of 102 files reviewed, 2 unresolved discussions (waiting on @culka)
metadata/hsl/databases/databases.yaml
line 7 at r1 (raw file):
database_url: from_env: HASURA_TIAMAT_DATABASE_URL isolation_level: read-committed
Other connections have isolation\_level: serializable
, any special reason for not using that?
metadata/hsl/databases/databases.yaml
line 12 at r1 (raw file):
naming_convention: hasura-default root_fields: namespace: stop_database
In other databases we have used plural (which would sound better anyway, in my opinion, because it sounds a bit less like a verb), so should we use stops_database
here? Also, the folder name tiamatdb
does not match this, is that fine?
Also database
-> db
would be an acceptable abbreviation I think, but this is fine as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 102 files reviewed, 3 unresolved discussions (waiting on @culka)
migrations/generic/metadata/readme.txt
line 1 at r1 (raw file):
Otherwise empty folder expected.
Could elaborate a little, if the purpose of these files is to ensure that the folder exists (for whatever reason).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 102 files at r1.
Reviewable status: 7 of 102 files reviewed, 3 unresolved discussions (waiting on @Leitsi)
metadata/hsl/databases/databases.yaml
line 7 at r1 (raw file):
Previously, Leitsi (Tommi Leinamo) wrote…
Other connections have
isolation\_level: serializable
, any special reason for not using that?
No real reason, this should not have any effects because writes are impossible, but let's use the same one.
metadata/hsl/databases/databases.yaml
line 12 at r1 (raw file):
Previously, Leitsi (Tommi Leinamo) wrote…
In other databases we have used plural (which would sound better anyway, in my opinion, because it sounds a bit less like a verb), so should we use
stops_database
here? Also, the folder nametiamatdb
does not match this, is that fine?Also
database
->db
would be an acceptable abbreviation I think, but this is fine as well.
Changed database to stops_database
Also yeah, tiamatdb
should rather be stops
, changed 👍
migrations/generic/metadata/readme.txt
line 1 at r1 (raw file):
Previously, Leitsi (Tommi Leinamo) wrote…
Could elaborate a little, if the purpose of these files is to ensure that the folder exists (for whatever reason).
Added a better description.
145d49f
to
b86cdf5
Compare
- Use the default database also as the metadata database - Create a direct connection to the Tiamat database - Track all public tables - Track all relevant parent -> child connections
b86cdf5
to
9a0e835
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 104 files reviewed, all discussions resolved (waiting on @culka)
Resolves HSLdevcom/jore4#1673
This change is