Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions for timetables API /to-combine endpoint #215

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

Leitsi
Copy link
Contributor

@Leitsi Leitsi commented Dec 8, 2023

This change is Reviewable

@Leitsi Leitsi marked this pull request as ready for review December 13, 2023 08:26
Copy link
Contributor

@jarkkoka jarkkoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Leitsi)


metadata/hsl/actions.graphql line 37 at r1 (raw file):

input ToCombineTargetVehicleScheduleFrameIdInput {
  stagingVehicleScheduleFrameId: uuid!

I'd like to have all these combine/replace definitions be consistently defined in the same order. For example, toCombineTargetVehicleScheduleFrameId comes before toReplaceVehicleScheduleFrameIds, but at the end of this file, the order is reversed.


metadata/hsl/actions.yaml line 62 at r1 (raw file):

    - name: ReplaceTimetablesInput
    - name: ToReplaceVehicleScheduleFrameIdsInput
    - name: ToCombineTargetVehicleScheduleFrameIdInput

I think combine defintions should be consistently before "replace"s to help the code reader.

Copy link
Contributor Author

@Leitsi Leitsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jarkkoka)


metadata/hsl/actions.graphql line 37 at r1 (raw file):

Previously, jarkkoka (Jarkko Kaura) wrote…

I'd like to have all these combine/replace definitions be consistently defined in the same order. For example, toCombineTargetVehicleScheduleFrameId comes before toReplaceVehicleScheduleFrameIds, but at the end of this file, the order is reversed.

Fixed. The order might've just come from Hasura since these were created via the UI.


metadata/hsl/actions.yaml line 62 at r1 (raw file):

Previously, jarkkoka (Jarkko Kaura) wrote…

I think combine defintions should be consistently before "replace"s to help the code reader.

Done.

Copy link
Contributor

@jarkkoka jarkkoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Leitsi)

@Leitsi Leitsi merged commit 779c9a8 into main Dec 15, 2023
11 checks passed
@Leitsi Leitsi deleted the combine-target-api branch December 15, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants