Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix journey pattern ref parsing in timetables data inserter #214

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Fix journey pattern ref parsing in timetables data inserter #214

merged 5 commits into from
Nov 21, 2023

Commits on Nov 20, 2023

  1. Move z.object call to a more appropriate place 

    Was like this for all other objects already.
    @Leitsi
    Leitsi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    48b4038 View commit details
    Browse the repository at this point in the history

  2. Don't allow extra properties in data inserter JSONs 

    Unfortunately there doesn't seem to be any "deep strict" mode in Zod,
so we have to add them individually like this.
    @Leitsi
    Leitsi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    77439c8 View commit details
    Browse the repository at this point in the history

  3. Only use default import for data inserter JSONs 

    Using star import would result in this kind of object being imported:
 {
    _vehicle_schedule_frames: [Getter],
    _journey_pattern_refs: [Getter],
    default: {
      _vehicle_schedule_frames: { ... },
      _journey_pattern_refs: { ... }
    }
  }
This is not valid when passed to the json schema parser.
    @Leitsi
    Leitsi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    4c50813 View commit details
    Browse the repository at this point in the history

  4. Add missing properties to data inserter json-schema

    @Leitsi
    Leitsi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    1984001 View commit details
    Browse the repository at this point in the history

  5. Remove an unnecessary export

    @Leitsi
    Leitsi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    81ba5b2 View commit details
    Browse the repository at this point in the history