Remove unused function get_vehicle_services_for_date #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
culka
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jarkkoka)
Earlier we created a more precise function get_vehicle_schedules_on_date, and replaced the use in front end with that. It is no more used and after a minor review it seems there is no use for this function any more, so removing it completely as dead code. Resolves HSLdevcom/jore4#1437
HenrikHartiala
force-pushed
the
remove-unused-function
branch
from
34a4f7b
to
df45edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we created a more precise function get_vehicle_schedules_on_date, and replaced the use in front end with that. It is no more used and after a minor review it seems there is no use for this function any more, so removing it completely as dead code.
Resolves HSLdevcom/jore4#1437
This change is