-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for including typings with data inserter #200
Add config for including typings with data inserter #200
Conversation
0c0fe56
to
efe9a88
Compare
Crypto is part of node and not working correctly with front end. It also had some problems even when building the timetables-data-inserter, so decided to change it to an external library.
This data inserter is planned to be used as the main test data inserter for all the repositories, but currently the other repositories could not use this yet since the builders couldn't figure out the typings on this sub module. Resolves HSLdevcom/jore4#1427
The day type id's are hardcoded values that are populated with migrations, we use the same id's everywhere and we do not want to expose the datasets so a more logical place would be in the data-inserter root.
efe9a88
to
7346c92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 36 of 36 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @HenrikHartiala)
-- commits
line 26 at r1:
Clearance
= eg. discount
, clarity
is probably what you mean here.
Suggestion:
for clarity
test/hasura/timetables-data-inserter/generic/data-insert.ts
line 21 at r1 (raw file):
closeDbConnection(dbConnection); return builtDataset; };
This could just use the insertGenericDataset
method. Also maybe rename result
.
Suggestion:
) => {
const datasetInput = parseGenericDatasetJson(input);
return insertGenericDataset(datasetInput, dbConfig);
};
test/hasura/timetables-data-inserter/hsl/data-insert.ts
line 13 at r1 (raw file):
input: string, dbConfig: ConnectionConfig = timetablesDbConfig, ) => {
Same here as on the generic side, use insertHslDataset
and renae result
.
add functions that take datasets as parameter instead of json. These functions can be used for example from front end. - Also move the inserter functions for clarity: "json-parser" does not indicate of any db insertions.
7346c92
to
430e5ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 34 of 36 files reviewed, 3 unresolved discussions (waiting on @Leitsi)
Previously, Leitsi (Tommi Leinamo) wrote…
Clearance
= eg.discount
,clarity
is probably what you mean here.
Ah yes, exactly! Thanks
test/hasura/timetables-data-inserter/generic/data-insert.ts
line 21 at r1 (raw file):
Previously, Leitsi (Tommi Leinamo) wrote…
This could just use the
insertGenericDataset
method. Also maybe renameresult
.
Ah good point! Thanks!
test/hasura/timetables-data-inserter/hsl/data-insert.ts
line 13 at r1 (raw file):
Previously, Leitsi (Tommi Leinamo) wrote…
Same here as on the generic side, use
insertHslDataset
and renaeresult
.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @HenrikHartiala)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @HenrikHartiala)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @HenrikHartiala)
This data inserter is planned to be used as the main test data inserter for all the repositories, but currently the other repositories could not use this yet since the builders couldn't figure out the typings on this sub module.
Resolves HSLdevcom/jore4#1427
This change is