Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fk constraints from return_value.timetable_version #198

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

HenrikHartiala
Copy link
Contributor

@HenrikHartiala HenrikHartiala commented Aug 23, 2023

These return_value schema tables are only for function return values, and they should not be part of the data model via any constraints.


This change is Reviewable

These return_value schema tables are only for function return values, and they should not
be part of the data model via any constraints.
Copy link
Contributor

@jarkkoka jarkkoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @culka and @HenrikHartiala)


-- commits line 4 at r1:
Good note! 👍


migrations/hsl/timetables/1692783935710_remove_foreign_key_constraints_on_return_value_timetable_version/down.sql line 6 at r1 (raw file):

ALTER TABLE return_value.timetable_version
  ADD CONSTRAINT timetable_version_substitute_operating_day_by_line_type_id_fkey

Whoa, the ID of this constraint was previously set to exactly at 63 character limit (any longer would be truncated).

Copy link
Contributor Author

@HenrikHartiala HenrikHartiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @culka and @jarkkoka)


-- commits line 4 at r1:

Previously, jarkkoka (Jarkko Kaura) wrote…

Good note! 👍

👌


migrations/hsl/timetables/1692783935710_remove_foreign_key_constraints_on_return_value_timetable_version/down.sql line 6 at r1 (raw file):

Previously, jarkkoka (Jarkko Kaura) wrote…

Whoa, the ID of this constraint was previously set to exactly at 63 character limit (any longer would be truncated).

ahh, that one :D Did not remember it. Well that was lucky

@HenrikHartiala HenrikHartiala merged commit daee0fa into main Aug 23, 2023
10 checks passed
@HenrikHartiala HenrikHartiala deleted the remove-fk-constraints-from-return-value branch August 23, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants