-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/park and ride model estimation #575
Open
hsl-petrhaj
wants to merge
22
commits into
feat/park-and-ride-model
Choose a base branch
from
feat/park-and-ride-model-estimation
base: feat/park-and-ride-model
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/park and ride model estimation #575
hsl-petrhaj
wants to merge
22
commits into
feat/park-and-ride-model
from
feat/park-and-ride-model-estimation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update VS Code instructions Solve issue with testing in updated version of VS Code * Update instructions --------- Co-authored-by: hsl-petrhaj <[email protected]>
* Move `CarUseModel` and `TourCombinationModel` into own modules Improve variable naming * Small improvements * Fix variable name clash * Make mode choice more stable for agents * Move money utility and fix `Person` unit test
* Fix use of deprecated Pandas and Numpy features * Fix initialization of integer Series and Dataframes when they should contain floats * Upgrade openpyxl to version compatible with python 3.11 * Keep zone_population as integer Series * Update development environment to OpenPaths EMME 24 --------- Co-authored-by: Sami Mäkinen <[email protected]>
…ully working. Zone spaces need to be addressed.
Bumps [numexpr](https://github.com/pydata/numexpr) from 2.8.4 to 2.8.5. - [Release notes](https://github.com/pydata/numexpr/releases) - [Changelog](https://github.com/pydata/numexpr/blob/master/RELEASE_NOTES.rst) - [Commits](pydata/numexpr@v2.8.4...v2.8.5) --- updated-dependencies: - dependency-name: numexpr dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: West Jens <[email protected]>
* Fix revenues summed too many times * Fix car revenue sum
…nto feat/park-and-ride-model-estimation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposal for implementing the park and ride assignment logic. I think we could merge this and then the for loop inside the split_park_and_ride function can be rewritten in pure numpy.
Tested with updated test network.