Realtime stop layer checks for existing stoptimes

HSLdevcom · May 22, 2024 · ca7e2a1 · ca7e2a1
1 parent fe41603
commit ca7e2a1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/...xt-test/java/org/opentripplanner/ext/vectortiles/layers/stops/RealtimeStopsLayerTest.java b/...xt-test/java/org/opentripplanner/ext/vectortiles/layers/stops/RealtimeStopsLayerTest.java
@@ -46,6 +46,7 @@ public void setUp() {
         .withName(name)
         .withDescription(desc)
         .withCoordinate(50, 10)
+        .withTimeZone(ZoneIds.HELSINKI)
         .build();
     stop2 =
       StopModel
@@ -54,6 +55,7 @@ public void setUp() {
         .withName(name)
         .withDescription(desc)
         .withCoordinate(51, 10)
+        .withTimeZone(ZoneIds.HELSINKI)
         .build();
   }
 
@@ -100,5 +102,6 @@ public TransitAlertService getTransitAlertService() {
     assertEquals("name", map.get("name"));
     assertEquals("desc", map.get("desc"));
     assertEquals(true, map.get("closedByServiceAlert"));
+    assertEquals(true, map.get("noServiceOnServiceDay"));
   }
 }
diff --git a/...g/opentripplanner/ext/vectortiles/layers/stops/DigitransitRealtimeStopPropertyMapper.java b/...g/opentripplanner/ext/vectortiles/layers/stops/DigitransitRealtimeStopPropertyMapper.java
@@ -3,13 +3,15 @@
 import static org.opentripplanner.ext.vectortiles.layers.stops.DigitransitStopPropertyMapper.getBaseKeyValues;
 
 import java.time.Instant;
+import java.time.LocalDate;
 import java.util.Collection;
 import java.util.List;
 import java.util.Locale;
 import org.opentripplanner.apis.support.mapping.PropertyMapper;
 import org.opentripplanner.framework.collection.ListUtils;
 import org.opentripplanner.framework.i18n.I18NStringMapper;
 import org.opentripplanner.inspector.vector.KeyValue;
+import org.opentripplanner.routing.stoptimes.ArrivalDeparture;
 import org.opentripplanner.transit.model.site.RegularStop;
 import org.opentripplanner.transit.service.TransitService;
 
@@ -32,10 +34,19 @@ protected Collection<KeyValue> map(RegularStop stop) {
       .stream()
       .anyMatch(alert -> alert.noServiceAt(currentTime));
 
+    var serviceDate = LocalDate.ofInstant(currentTime, transitService.getTimeZone());
+    boolean stopTimesExist = transitService
+      .getStopTimesForStop(stop, serviceDate, ArrivalDeparture.BOTH, true)
+      .stream()
+      .anyMatch(stopTime -> stopTime.times.size() > 0);
+
     Collection<KeyValue> sharedKeyValues = getBaseKeyValues(stop, i18NStringMapper, transitService);
     return ListUtils.combine(
       sharedKeyValues,
-      List.of(new KeyValue("closedByServiceAlert", noServiceAlert))
+      List.of(
+        new KeyValue("closedByServiceAlert", noServiceAlert),
+        new KeyValue("noServiceOnServiceDay", !stopTimesExist)
+      )
     );
   }
 }