Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ adds Cans list summary card for Total Budget #2979

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Oct 24, 2024

What changed

  • adds LineGraphWithLegendCard and friends
  • organize components
  • created new UI/DataViz directory to house charts and graphs

Issue

#2842 #2971

How to test

  1. see e2e test pass
  2. goto CANs list
  3. see summary card
  4. 💰 profit

Screenshots

Screen.Recording.2024-10-25.at.4.04.45.PM.mov

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

moved to its own component
@fpigeonjr fpigeonjr self-assigned this Oct 24, 2024
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Oct 24, 2024
* @param {LineGraphWithLegendCardProps} props
* @returns {JSX.Element}
*/
const LineGraphWithLegendCard = ({ data = [], bigNumber, heading }) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ crux of the PR is here

@fpigeonjr fpigeonjr changed the title wip: CAN Total Budget Summary Card feat: ✨ adds Cans list summary card for Total Budget Oct 25, 2024
@fpigeonjr fpigeonjr marked this pull request as ready for review October 25, 2024 21:03
@fpigeonjr
Copy link
Contributor Author

image

👀 don't be scared, mostly organizing components and fixing imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant