Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops 2662 can migration 3 #2975

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Ops 2662 can migration 3 #2975

wants to merge 40 commits into from

Conversation

johndeange
Copy link
Contributor

@johndeange johndeange commented Oct 23, 2024 •
edited
Loading

What changed

  • Added script to load CAN and CANFundingDetails from TSV file.
  • Integrated "disable users" script with recent data tools changes.

Issue

#2662

How to test

Automated tests pass.

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

@johndeange
move history triggers to the models package
3466b21 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
added loguru and sorted the dependencies
35f25fc 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
Merge branch 'OPS-2662-can-migration-2' into OPS-2662-can-migration-3
c9fa6c1
@johndeange
added loguru logging config
da6d33c 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
set timezone and enhance log config
50cdfa8 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
setup DB metadata in fixture and create DB session
213dc13 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
setup timezone and logger config
e2c1b25 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
add initial tests
e55b033 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
add initial can code
9d1be5f 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
add initial can code
fbb4d02 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
Merge branch 'main' into OPS-2662-can-migration-3
e3eb4ae 
# Conflicts:
#	backend/ops_api/Pipfile
#	backend/ops_api/Pipfile.lock
@johndeange
update lock file
ea31d78 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
move to separate test package
af22b3f 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
copy dict values into list; wrap marshmallow schema safe user in a tr…
788de85 
…y block

Signed-off-by: John DeAngelis <[email protected]>
@johndeange
add etl user; add history triggers to pytest
7209c62 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
use api db module (with modifications) to data tools
008d6a7 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
move test to separate module
38565d3 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
add tests
767f3b5 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
use init_db from db module
2ac2153 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
add created_by to script
fe93547 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
complete the main script; add sys_user fixture
b89d390 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
Merge branch 'main' into OPS-2662-can-migration-3
29cfd8b 
# Conflicts:
#	backend/models/utils.py
@johndeange
merge with work from disable_users.py
62ef4a1 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
add integration test for main entrypoint
384a603 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
use session instead of engine to get sys_user
a49d081 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
renamed script
9143af1 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
remove sys_user pytest fixture
35b0578 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
move init_db_from_config
cafbfae 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
move init_db_from_config
3aa11d2 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange
move init_db_from_config
443224a 
Signed-off-by: John DeAngelis <[email protected]>
@johndeange johndeange marked this pull request as draft October 23, 2024 21:15
@johndeange johndeange marked this pull request as ready for review October 24, 2024 01:52
fpigeonjr
fpigeonjr reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@fpigeonjr fpigeonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 tests pass, will defer to others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpigeonjr fpigeonjr fpigeonjr left review comments

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@maiyerlee maiyerlee maiyerlee approved these changes

@devops-chris devops-chris Awaiting requested review from devops-chris

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

Assignees

@johndeange johndeange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johndeange @rajohnson90 @fpigeonjr @maiyerlee