Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ adds Budget Summary Card #2974

Merged
merged 8 commits into from
Oct 24, 2024
Merged

feat: ✨ adds Budget Summary Card #2974

merged 8 commits into from
Oct 24, 2024

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Oct 23, 2024 •
edited
Loading

What changed

  • adds Budget Summary Card w/ hard-coded values for now

Issue

#2842 #2972

How to test

  1. Goto the Cans List
  2. See Budget Summary Card
  3. 💰 profit

Screenshots

image

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr changed the title wip: starts CANs summary cards feat: ✨ adds Budget Summary Card Oct 23, 2024
@fpigeonjr fpigeonjr self-assigned this Oct 23, 2024
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Oct 23, 2024
@fpigeonjr fpigeonjr marked this pull request as ready for review October 23, 2024 21:49
fpigeonjr
fpigeonjr commented Oct 24, 2024
View reviewed changes
frontend/src/components/CANs/CANSummaryCards/CANSummaryCards.jsx
<p> Summary Cards Left</p>
<BudgetSummaryCard
title={`FY ${fiscalYear} CANs Available Budget *`}
totalSpending={1_500_000}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard-coded for now but will replace with api data

maiyerlee
maiyerlee approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@maiyerlee maiyerlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fpigeonjr fpigeonjr merged commit 4bcf572 into main Oct 24, 2024
40 checks passed
@fpigeonjr fpigeonjr deleted the OPS-2842/2972 branch October 24, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndeange johndeange johndeange approved these changes

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@maiyerlee maiyerlee maiyerlee approved these changes

@jonnalley jonnalley Awaiting requested review from jonnalley

@devops-chris devops-chris Awaiting requested review from devops-chris

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

Assignees

@fpigeonjr fpigeonjr

@Santi-3rd Santi-3rd

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fpigeonjr @johndeange @rajohnson90 @maiyerlee @Santi-3rd