Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude USWDS .svg files from eol pre-commit #1845

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Exclude USWDS .svg files from eol pre-commit #1845

merged 1 commit into from
Jan 8, 2024

Conversation

tdonaworth
Copy link
Collaborator

What changed

Simple change, for those who newly install pre-commit, or run with --all-files, this will NOT modify the USWDS .svg files by adding a newline.

How to test

  1. run pre-commit run --all-files from the root of the project
  2. You should NOT see any .svg files within frontend/src/uswds modified

@tdonaworth tdonaworth merged commit 144f25a into main Jan 8, 2024
10 checks passed
@tdonaworth tdonaworth deleted the patch-Update-precommit-exclude-svg branch January 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnalley jonnalley jonnalley approved these changes

@fpigeonjr fpigeonjr fpigeonjr approved these changes

@devops-chris devops-chris Awaiting requested review from devops-chris

@johndeange johndeange Awaiting requested review from johndeange

@stevtek stevtek Awaiting requested review from stevtek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdonaworth @jonnalley @fpigeonjr