Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3221] Parameterize the memory usage of the ClamAV app #15

Open
wants to merge 1 commit into
base: ohs-deploy-dev
Choose a base branch
from

Conversation

GarrettEHill
Copy link
Collaborator

@GarrettEHill GarrettEHill commented Oct 23, 2024

Description:

  1. Parameterized Memory Configuration: The memory usage for the ClamAV application has been parameterized to allow flexible memory allocation across different environments (e.g., development and production). Instead of hardcoding the memory value in the manifest.yml, it now uses a variable ((memory)), which pulls the memory value from external configuration files.
  2. Deployment Configuration Files: Two new configuration files were added—deployment_config/dev_vars.yml and deployment_config/prod_vars.yml. These files specify memory allocation for the ClamAV app, with 2G allocated for the development environment and 4G for production.
  3. CI/CD Pipeline Update: The .circleci/config.yml file has been updated to include a new parameter, deploy_config_file, which points to the appropriate deployment configuration file (either dev_vars.yml or prod_vars.yml) based on the environment being deployed to. This ensures that the correct memory configuration is applied during the application deployment process.

@GarrettEHill GarrettEHill marked this pull request as ready for review October 23, 2024 22:02
@thewatermethod
Copy link
Collaborator

My bad on the previous comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants