-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTAHUB-3061] Generate processed dataset to remove PII in CI #2299
base: main
Are you sure you want to change the base?
Conversation
…TAHUB-3061/process-data
src/lib/s3.test.js
Outdated
it('throws an error if promise rejects', async () => { | ||
mockS3.deleteObject.mockImplementation( | ||
() => ({ promise: () => Promise.reject(anotherFakeError) }), | ||
); | ||
const got = deleteFileFromS3(Key, undefined, mockS3); | ||
await expect(got).rejects.toBe(anotherFakeError); | ||
expect(mockS3.deleteObject).toHaveBeenCalledWith({ Bucket, Key }); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some reason why you are passing undefined as bucket name? it doesn't seem to be part of the test, and passing it as undefined means it defaults to the destructured value from the s3config function, so line 274 will not pass. I'm just not clear as to what we are trying to test here.
Description of change
How to test
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy