-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openapi #1972
base: main
Are you sure you want to change the base?
Openapi #1972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to understand what this is all doing, seems like a mix of things
@@ -33,7 +35,7 @@ services: | |||
depends_on: | |||
- minio | |||
clamav-rest: | |||
image: ajilaag/clamav-rest | |||
image: kcirtapfromspace/clamav-rest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is yours, but I see that no one else is maintaining a cross platform version.
I think we need to reconfigure the clamav settings. As the import system is attempting to queue all the files its placing on s3 to be scanned. But they are ~75MB each.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just to build arm64 on m1 machines. open pr to clam for the to build arm ajilach/clamav-rest#37
"server": "tsx watch --trace-warnings src/index.ts", | ||
"worker": "tsx watch --trace-warnings src/worker.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it get run with this flag in production or just in dev environments?
"docker:dbs:start": "docker-compose -f 'docker-compose.yml' up", | ||
"docker:dbs:stop": "docker-compose -f 'docker-compose.yml' down", | ||
"docker:start": "docker compose up", | ||
"docker:start:debug": "docker compose --compatibility -f docker compose.yml -f docker compose.debug.yml up", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you went a little overzealous with ,your find/replace. the filename should still be docker-compose.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it get run with this flag in production or just in dev environments?
This is just to build arm64 on m1 machines. open pr to clam for the to build armhttps://github.com/ajilach/clamav-rest/pull/37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it get run with this flag in production or just in dev environments?
Probably better to have the conversation on #1970 as that is focused on developer build systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you went a little overzealous with ,your find/replace. the filename should still be docker-compose.yml
Probably better to have the conversation on #1970 as that is focused on developer build systems
Confused about the aim here - we already serve the open API docs as part of the docker container network, is the idea to remove that container and serve them on cloud.gov? |
Yeah, I'm thinking this is a would an easy method that serves load test tools the api docs url. If the docs are auto generated with jsDoc comments we shouldn't have to spell out yaml files. https://k6.io/blog/load-testing-your-api-with-swagger-openapi-and-k6/ |
Note this is not working, thus draft.
Also was trying to get auto generated openapi docs. Though, admittedly i’m not clear on configuring the routes between the frontend & backend.
This is rebased with the docker image caching #1970
Description of change
Looking to add openapi documentation.
How to test
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy