Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release mcan/0.5.0 #48

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Release mcan/0.5.0 #48

merged 1 commit into from
Mar 4, 2024

Conversation

Ironedde
Copy link
Contributor

@Ironedde Ironedde commented Mar 4, 2024 •
edited
Loading

Release 0.5.0

Added

Changed

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All tests pass and in the best case you also added new tests.
  • cargo +stable fmt was run.
  • cargo +stable clippy yields no warnings.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You add a description of your work to this PR.
  • You added proper docs (in code, rustdoc and README.md) for your
    newly added features and code.

@Ironedde Ironedde requested a review from a team as a code owner March 4, 2024 15:05
@Ironedde
Copy link
Contributor Author

Ironedde commented Mar 4, 2024

Todo after merge

  • Add tag mcan/0.5.0 to the master branch
  • Publish to crates.io

@Ironedde Ironedde requested review from epontan and vcrn March 4, 2024 15:13
vcrn
vcrn previously approved these changes Mar 4, 2024
View reviewed changes
Copy link

@vcrn vcrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

epontan
epontan requested changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@epontan epontan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just update the date

mcan/CHANGELOG.md Outdated
@@ -3,10 +3,16 @@
Tagging in git follows a pattern: `mcan/<version>`.

## [Unreleased]
- *Breaking* Update the register mappings with svd2rust 0.30.2 and form 0.10.0 (#46)

## [0.5.0] - 2023-10-24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong date 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, copy paste always fails 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

@Ironedde
Release mcan/0.5.0
d01ae22 
- Add safe way to shutdown the bus when actively transmitting/receiving
(GrepitAB#45)
- Add method to finalize configuration into initialization mode (GrepitAB#47)

- *Breaking* Update the register mappings with svd2rust 0.30.2 and
form 0.10.0 (GrepitAB#46)
epontan
epontan approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@epontan epontan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍

@Ironedde Ironedde merged commit 5eadb2a into GrepitAB:master Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epontan epontan epontan approved these changes

@vcrn vcrn vcrn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ironedde @epontan @vcrn