-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better auto interval handling #15940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todvora: The thing is that the auto interval calculates the width of bars differently. Previously, each bar was |
@todvora @dennisoelkers |
@luk-kaminski: This is the rationale for the current implementation: https://github.com/Graylog2/graylog-plugin-enterprise/pull/358 |
@dennisoelkers - Thanks for that! But the "data gap" problem that @todvora has bothered me quite a lot - it will be a surprising side effect of the change for some people... |
The discussion continues on slack.
|
Unit tests Auto values only for all messages
cea8c56
to
5380dd0
Compare
Description
Fixes #14906.
Current approach did not work well with auto interval and long time ranges (like "All time"), especially for relatively fresh systems.
The biggest interval was 1 month, while "All time" means around 50 years in GL... So all data used to land in 1 bucket.
The implementation has been changed, so that AutoDateHistogramAggregationBuilder is used. We allow ES/OS to select interval, do not do it ourselves for auto interval, just providing some clue for number of expected buckets, using
scaling
field./nocl
Motivation and Context
See #14906.
How Has This Been Tested?
Manually and with new unit tests.
Types of changes
Checklist: