Correctly normalize keyword time range for search bar form when selecting keyword time range. #15938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
force-pushed
the
issue-15472
branch
3 times, most recently
from
301d68e
to
fa64563
Compare
dennisoelkers
approved these changes
Jul 20, 2023
Before this change a keyword time range in the search bar form could have not needed `from` and `to` attributes.
linuspahl
added a commit
that referenced
this pull request
Jul 21, 2023
…ting keyword time range. (#15938) * Normalize keyword time range for search bar form. Before this change a keyword time range in the search bar form could have not needed `from` and `to` attributes. * Adding test * Adding changelog
4 tasks
linuspahl
added a commit
that referenced
this pull request
Jul 21, 2023
…ting keyword time range. (#15938) * Normalize keyword time range for search bar form. Before this change a keyword time range in the search bar form could have not needed `from` and `to` attributes. * Adding test * Adding changelog
linuspahl
added a commit
that referenced
this pull request
Jul 24, 2023
…ting keyword (`5.0`) (#16013) * Correctly normalize keyword time range for search bar form when selecting keyword time range. (#15938) * Normalize keyword time range for search bar form. Before this change a keyword time range in the search bar form could have not needed `from` and `to` attributes. * Adding test * Adding changelog * Cleanup
linuspahl
added a commit
that referenced
this pull request
Jul 24, 2023
…ting keyword time range. (`5.1`) (#16012) * Correctly normalize keyword time range for search bar form when selecting keyword time range. (#15938) * Normalize keyword time range for search bar form. Before this change a keyword time range in the search bar form could have not needed `from` and `to` attributes. * Adding test * Adding changelog * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: this PR requires a backport for
5.0and5.1Description
Motivation and Context
Before this change a keyword time range in the search bar form could have not needed
fromandtoattributes. These attributes:As a result the search bar form button was incorrectly displayed as dirty, in some cases (see #15472)
Fixes: #15471
Fixes: #15472
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes