-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring certificate renewal policy through system configurations. #15921
Conversation
dd458b0
to
f1f8e05
Compare
bsStyle="success" | ||
disabled={isSubmitting}>{isSubmitting ? 'Updating configuration' : 'Update configuration'} | ||
</Button> | ||
</Modal.Footer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we can use the ModalSubmit
component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the review I realised the changes to TimeUnitInput
could affect components which use the default TimeUnitInput
prop for units
(AbuseChRansomAdapterFieldSet
, MaxmindAdapterFieldSet
, CaffeineCacheFieldSet
).
bf60101
to
70c9025
Compare
Note: This PR is based on #15882, which should be merged first.
Description
Motivation and Context
This PR is adding a configlet that allows the user to configure the current certificate renewal policy.
/nocl
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: