Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring certificate renewal policy through system configurations. #15921

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Allow configuring certificate renewal policy through system configurations. #15921

merged 5 commits into from
Jul 18, 2023

Conversation

dennisoelkers
Copy link
Member

Note: This PR is based on #15882, which should be merged first.

Description

Motivation and Context

This PR is adding a configlet that allows the user to configure the current certificate renewal policy.

/nocl

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers changed the title Allow configuring certificatel renewal policy through system configurations. Allow configuring certificate renewal policy through system configurations. Jul 10, 2023
@dennisoelkers dennisoelkers marked this pull request as ready for review July 14, 2023 07:58
linuspahl
linuspahl requested changes Jul 14, 2023
View reviewed changes
graylog2-web-interface/src/components/configurations/CertificateRenewalPolicyConfig.tsx
bsStyle="success"
disabled={isSubmitting}>{isSubmitting ? 'Updating configuration' : 'Update configuration'}
</Button>
</Modal.Footer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we can use the ModalSubmit component.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

linuspahl
linuspahl requested changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the review I realised the changes to TimeUnitInput could affect components which use the default TimeUnitInput prop for units (AbuseChRansomAdapterFieldSet, MaxmindAdapterFieldSet, CaffeineCacheFieldSet).

@dennisoelkers dennisoelkers merged commit f1604cd into master Jul 18, 2023
2 checks passed
@dennisoelkers dennisoelkers deleted the feat/configure-renewal-policy branch July 18, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linuspahl linuspahl linuspahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisoelkers @linuspahl