Enhanced Pipeline RuleUI #15851
Merged
Enhanced Pipeline RuleUI #15851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract function table into own component * Migrate RuleHelper to typescript and functional component * Add help icon and popover to rule block form
backend for graylog/graylog-plugin-enterprise#5414
patrickmann
reviewed
Aug 7, 2023
graylog2-server/src/main/java/org/graylog/plugins/pipelineprocessor/functions/IsNull.java
Outdated
Show resolved
Hide resolved
|
These functions lack a primary parameter: |
patrickmann
reviewed
Aug 7, 2023
...2-server/src/main/java/org/graylog/plugins/pipelineprocessor/functions/conversion/IsMap.java
Outdated
Show resolved
Hide resolved
patrickmann
reviewed
Aug 7, 2023
...rver/src/main/java/org/graylog/plugins/pipelineprocessor/functions/messages/DropMessage.java
Outdated
Show resolved
Hide resolved
patrickmann
reviewed
Aug 7, 2023
...src/main/java/org/graylog/plugins/pipelineprocessor/functions/messages/RemoveFromStream.java
Outdated
Show resolved
Hide resolved
patrickmann
reviewed
Aug 7, 2023
...server/src/main/java/org/graylog/plugins/pipelineprocessor/functions/strings/Capitalize.java
Outdated
Show resolved
Hide resolved
|
|
patrickmann
reviewed
Aug 7, 2023
...ugins/pipelineprocessor/rulebuilder/db/migrations/V20230720161500_AddExtractorFragments.java
Outdated
Show resolved
Hide resolved
...ugins/pipelineprocessor/rulebuilder/db/migrations/V20230720161500_AddExtractorFragments.java
Show resolved
Hide resolved
...ugins/pipelineprocessor/rulebuilder/db/migrations/V20230720161500_AddExtractorFragments.java
Outdated
Show resolved
Hide resolved
.../test/java/org/graylog/plugins/pipelineprocessor/rulebuilder/parser/ConditionParserTest.java
Show resolved
Hide resolved
.../test/java/org/graylog/plugins/pipelineprocessor/rulebuilder/parser/ConditionParserTest.java
Show resolved
Hide resolved
Added the primary parameter for all functions which already have rule builder metadata (e.g. not for the syslog ones) |
ousmaneo
approved these changes
Aug 10, 2023
| <Modal.Footer> | ||
| <Button type="button" | ||
| bsStyle="success" | ||
| onClick={async () => { |
There was a problem hiding this comment.
Can we extract this to a function?
| Save | ||
| </Button> | ||
| <Button type="button" | ||
| onClick={() => { |
There was a problem hiding this comment.
Can we also extract this to a function?
bernd
pushed a commit
that referenced
this pull request
Aug 16, 2023
* initial setup * Rule Builder UI Help Icon (#15883) * Extract function table into own component * Migrate RuleHelper to typescript and functional component * Add help icon and popover to rule block form * generate simulator output * Show function description in select list * updated Cols to use xs * Enhanced Simulator progress * fix eslint issue * add function groups and human readable names backend for graylog/graylog-plugin-enterprise#5414 * Fix color for selected Option description and help box width * set rulebuilder descriptor and primary param * set rulebuilder descriptor and primary param * set rulebuilder descriptor and primary param * set rulebuilder descriptor and primary param * fix: sort by rulebuilder name * set rulebuilder descriptor and primary param * remove boolean functions from actions * Show output and use rule_builder_name * repositioned Show Simulator * display a simpler version of Rule Ref on RuleBuilder * add SourceCodeEditor button * fix reset simulation * update css heights * fix: generate simulator fields only on simulate * put rule builder step variables into custom result node * evaluate conditions in simulation * Show select list for output variables for primary inputs * Generate dynamic output variable list and show filtered list in fields * Remove unused functions and code * Don't add or update when required fields are missing and mark optional fields * Fix proptype for RuleHelperTable * Show variable names in Block Display * Fix linter errors in Input component * Fix input console error * fix getDictForFunction undefined error * Filter out variables without output and rename output var name * readd handling of undefined dict in outputvariables * Fix wrong license header in RuleBuilder * integrated simulation api changes * real time simulation * show simulation conditions/actions outputs * add condition groups * fix failing tests, adjust to grouped conditions * Rule Simulation label * Remove params from display * updated conditions/actions output keys * add extractor fragments and fragment tests * Show return type next to output * Reduce spacing between output and block headline * Fix existing tests and add new test cases * Fix type errors and remove attrs usage in styled components * add field type conditions, remove type check conditions, add metadata * add date functions, add metadata * added unit tests to simulator * add string functions, function metadata * unit test for simulator conditions/actions output * fix missing name and conditions * fixed tests * direct navigation to rule builder after clicking create rule button * add string conditions * fix condition titles * clean up conditions * fix delete rule errors * reposition sourceCodeEditor button and showSimulator switch * Don't check for previousOutputPresent anymore * Move Toggle to it's own component * use theme spacing * navigate to rules list onCancel instead of history.goBack * add additional extractors and tests * add grok matches condition * Fix simulation result reset with the default simulation message when updating an action * converted Rule.jsx to typescript * Declare variableType as optional on type and propTypes * fix grok matches and grok extractor, add tests * update grok extractor title * fix booleans in titles * add suppress forbiddenapi usage in tests * add split index extractor * disable functions with incompatible return types and parameters * disable functions with incompatible return types and parameters * fix reenable set_field * add lookup extractor * add lookup extractor fragment * added ConfirmNavigateToSourceCodeEditorModal * Function typos, missing primary parameters * Update logger name Co-authored-by: Patrick Mann <[email protected]> * completely remove deleted test * fix logger name * move `addFragment` upsert functionality to `RuleFragmentService` * extract functions --------- Co-authored-by: Laura Bergenthal-Grotlüschen <[email protected]> Co-authored-by: Laura <[email protected]> Co-authored-by: Matthias Oesterheld <[email protected]> Co-authored-by: Matthias Oesterheld <[email protected]> Co-authored-by: Patrick Mann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/nocl
Types of changes
Checklist: