Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for OpenSearch and blocked index/cluster after watermark hit #15420

Merged
merged 31 commits into from
Jul 17, 2023
Merged

Fix tests for OpenSearch and blocked index/cluster after watermark hit #15420

merged 31 commits into from
Jul 17, 2023

Conversation

janheise
Copy link
Contributor

@janheise janheise commented May 4, 2023 •
edited
Loading

Description

OpenSearch 2.6 has a change that after a watermark for the full cluster fails, only resetting the index block is not enough.
cluster.blocks.create_index needs also to get reset.

/nocl

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise mentioned this pull request May 4, 2023
Closed
9 tasks
@janheise janheise marked this pull request as ready for review May 4, 2023 11:53
@janheise janheise requested a review from todvora May 4, 2023 11:54
@janheise janheise force-pushed the fix/opensearch2_6_0_support branch from 94f8697 to 690f0d3 Compare May 4, 2023 13:07
@janheise janheise marked this pull request as draft May 4, 2023 14:40
@janheise janheise force-pushed the fix/opensearch2_6_0_support branch from 690f0d3 to e3f06c4 Compare May 5, 2023 07:35
todvora
todvora approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janheise janheise force-pushed the fix/opensearch2_6_0_support branch from 90ceb01 to c115877 Compare May 8, 2023 11:56
@janheise janheise changed the title Support for using a non cached OpenSearch container in old style IT tests Fix tests for OpenSearch and blocked index/cluster after watermark hit May 8, 2023
todvora
todvora approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janheise janheise marked this pull request as ready for review May 9, 2023 16:38
@janheise janheise marked this pull request as draft May 10, 2023 07:43
todvora
todvora approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@todvora todvora self-assigned this Jun 19, 2023
@todvora todvora force-pushed the fix/opensearch2_6_0_support branch from d779788 to 45c388d Compare July 11, 2023 13:54
@janheise janheise marked this pull request as ready for review July 12, 2023 10:33
@janheise janheise mentioned this pull request Jul 12, 2023
Closed
9 tasks
@janheise janheise marked this pull request as draft July 12, 2023 14:57
@janheise janheise marked this pull request as ready for review July 17, 2023 07:23
@janheise janheise merged commit 259fffb into master Jul 17, 2023
1 check passed
@janheise janheise deleted the fix/opensearch2_6_0_support branch July 17, 2023 09:17
janheise added a commit that referenced this pull request Jul 17, 2023
@janheise
Revert "Fix tests for OpenSearch and blocked index/cluster after wate…
f393cab 
…rmark hit (#15420)"

This reverts commit 259fffb.
@janheise janheise mentioned this pull request Jul 17, 2023
Merged
@janheise janheise restored the fix/opensearch2_6_0_support branch July 17, 2023 15:13
dennisoelkers pushed a commit that referenced this pull request Jul 18, 2023
@janheise
Revert "Fix tests for OpenSearch and blocked index/cluster after wate…
12f8c81 
…rmark hit (#15420)" (#15971)

This reverts commit 259fffb.
@todvora todvora mentioned this pull request Jul 18, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todvora todvora todvora approved these changes

@dennisoelkers dennisoelkers Awaiting requested review from dennisoelkers

Assignees

@todvora todvora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janheise @todvora