Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write support for uncompressed metablocks #204

Merged
merged 3 commits into from
Jan 1, 2024
Merged

Conversation

Gottox
Copy link
Owner

@Gottox Gottox commented Dec 31, 2023

ToDo:

  • Use metablock reader to set up metablocks in tests.

@Gottox Gottox changed the title Add/write support metablock write support for uncompressed metablocks Dec 31, 2023
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (26c6f29) 63.80% compared to head (8321cef) 63.91%.

Files Patch % Lines
libmksqsh/src/metablock/metablock_builder.c 72.91% 9 Missing and 4 partials ⚠️
common/src/data/metablock_set.c 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   63.80%   63.91%   +0.10%     
==========================================
  Files          70       72       +2     
  Lines        5277     5334      +57     
  Branches      764      771       +7     
==========================================
+ Hits         3367     3409      +42     
- Misses       1488     1498      +10     
- Partials      422      427       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gottox
Copy link
Owner Author

Gottox commented Dec 31, 2023

ref: #126

Copy link

sonarcloud bot commented Jan 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Gottox Gottox marked this pull request as ready for review January 1, 2024 21:37
@Gottox Gottox merged commit e6b1bfa into main Jan 1, 2024
28 checks passed
@Gottox Gottox deleted the add/write-support-metablock branch January 7, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant