use pydantic v2 backwards compat mode #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NexAdn
force-pushed
the
pydantic-v2-compat
branch
2 times, most recently
from
3d958e9
to
389b5e6
Compare
ryneeverett
reviewed
Sep 17, 2024
NexAdn
added a commit
to NexAdn/bugwarrior
that referenced
this pull request
Sep 19, 2024
This should allow using the existing pydantic v1 features while migration to v2 is not done. This also raises the minimum requirement to pydantic >= 2, as the v1 compat modules are not available in pydantic v1. As discussed in the PR [0], this new version requirement was accepted due to widespread adoption of pydantic v2 in major distributions. Issue: GothenburgBitFactory#998 [0] GothenburgBitFactory#1068 (review)
NexAdn
force-pushed
the
pydantic-v2-compat
branch
from
389b5e6
to
fff27c8
Compare
|
I believe CI is failing because pydantic-2 dropped support for python-3.6. I just removed 3.6 from the test matrix -- we don't need to support it anyways -- so if you rebase on |
NexAdn
force-pushed
the
pydantic-v2-compat
branch
from
fff27c8
to
a702ea2
Compare
NexAdn
added a commit
to NexAdn/bugwarrior
that referenced
this pull request
Sep 19, 2024
This should allow using the existing pydantic v1 features while migration to v2 is not done. This also raises the minimum requirement to pydantic >= 2, as the v1 compat modules are not available in pydantic v1. As discussed in the PR [0], this new version requirement was accepted due to widespread adoption of pydantic v2 in major distributions. Issue: GothenburgBitFactory#998 [0] GothenburgBitFactory#1068 (review)
This should allow using the existing pydantic v1 features while migration to v2 is not done. This also raises the minimum requirement to pydantic >= 2, as the v1 compat modules are not available in pydantic v1. As discussed in the PR [0], this new version requirement was accepted due to widespread adoption of pydantic v2 in major distributions. Issue: GothenburgBitFactory#998 [0] GothenburgBitFactory#1068 (review)
NexAdn
force-pushed
the
pydantic-v2-compat
branch
from
a702ea2
to
0b1f4f7
Compare
Rebase done, CI seems to be happy now |
ryneeverett
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow using the existing pydantic v1 features while migration to v2 is not done.
Issue: #998