KCC Composition Sample (jinja2) for Eventarc #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barney-s
reviewed
Oct 2, 2024
experiments/compositions/samples/Eventarc/eventarc-composition.yaml
Outdated
Show resolved
Hide resolved
experiments/compositions/samples/Eventarc/eventarc-composition.yaml
Outdated
Show resolved
Hide resolved
experiments/compositions/samples/Eventarc/eventarc-composition.yaml
Outdated
Show resolved
Hide resolved
|
Thanks, updated the PR. For values that couldn't be parametrized, I left the values from my test project in (the intent being that someone could use this directly, and just enter in their project number/ID and have it working). |
svetakvsundhar
changed the title
barney-s
reviewed
Oct 7, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides a sample (with
ReadMeinstructions) to create a KCC Composition to spin up GCP EventArc. This example uses ajinja2template.Tested on GCP Sandbox
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.