Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): respect collect puppeteerLaunchOptions.headless #1051

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

connorjclark
Copy link
Collaborator

Fixes #947 by only overriding to headless: false when --headful is present.

@connorjclark connorjclark changed the title fix(cli): respect value of collect puppeteerLaunchOptions.headless fix(cli): respect collect puppeteerLaunchOptions.headless Jun 24, 2024
@connorjclark connorjclark merged commit 03eff8f into main Jun 24, 2024
6 checks passed
@connorjclark connorjclark deleted the pup-headless-arg branch June 24, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The puppeteerLaunchOptions seems not working
1 participant