Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(chrome-versions): add test for chrome-versions.js #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions tests/lib/chrome-versions.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/**
* Copyright 2022 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import test from 'ava';
import {
splitChromeRelease,
chromeVersions,
chromePublishedStable,
} from '../../tools/lib/chrome-versions.js';

test('splitChromeRelease', async (t) => {
/** @type {any} */
let scr;

// Returns undefined if too few parts
scr = await splitChromeRelease('88.0.4324');
t.is(scr, undefined);

// Returns undefined if too many parts
scr = await splitChromeRelease('88.0.4324.1.1');
t.is(scr, undefined);

// Returns major version is invalid
scr = await splitChromeRelease('a.b.c.d');
t.is(scr, undefined);

// Returns undefined if semantic version is invalid
scr = await splitChromeRelease('88.0.a.1');
t.is(scr, undefined);

// Returns release and rest of release tag if valid
scr = await splitChromeRelease('88.0.4324.47');
t.deepEqual(Object.keys(scr), ['release', 'rest']);
t.is(typeof scr.release, 'number');
t.is(typeof scr.rest, 'string');
});

test('chromeVersions', async (t) => {
// Returns head and map of chrome version releases
const cv = await chromeVersions();
t.is(typeof cv.head, 'string');
t.is(cv.releases instanceof Map, true);
t.is(cv.releases.size > 0, true);
t.deepEqual(Object.keys(cv), ['head', 'releases']);
})

test('chromePublishedStable', async (t) => {
// Returns number representing current stable version of Chrome
const cps = await chromePublishedStable();
t.is(typeof cps, 'number');
});
4 changes: 2 additions & 2 deletions tools/lib/chrome-versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const omahaProxyUrl = 'https://omahaproxy.appspot.com/all.json';
/**
* @param {string} tag
*/
function splitChromeRelease(tag) {
export async function splitChromeRelease(tag) {
// Look for versions like "88.0.4324.47". Ignore other tags.
const parts = tag.split('.');
if (parts.length !== 4) {
Expand Down Expand Up @@ -99,7 +99,7 @@ export async function chromeVersions() {
continue;
}
const tag = rawTag.substr(tagPrefix.length);
const info = splitChromeRelease(tag);
const info = await splitChromeRelease(tag);
if (!info) {
continue;
}
Expand Down