Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.15] Add support for listing merge requests associated with a commit #789

Open
wants to merge 1 commit into
base: 11.15
Choose a base branch
from

Conversation

zluiten
Copy link

@zluiten zluiten commented Jan 12, 2024

Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started. I've left a note inline to be addressed. I know existing code is not always with this doc, but net new code needs it.

*
* @return mixed
*/
public function commitMergeRequests($project_id, string $sha, array $parameters = [])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need param documentation and validation for the supported parameters please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the "parameters" parameter as this api endpoint does not seem to support any parameters.

@GrahamCampbell GrahamCampbell changed the title Add support for listing merge requests associated with a commit [11.15] Add support for listing merge requests associated with a commit Mar 17, 2024
@GrahamCampbell GrahamCampbell changed the base branch from 11.13 to 11.15 March 17, 2024 21:39
@zluiten zluiten force-pushed the feature-add-support-for-commit-merge-requests branch from e0dc93d to 139f663 Compare April 25, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants